Skip to content

Fix stray \ before + error caused by grep in load_eessi_extend_module.sh #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ocaisa merged 1 commit into from
Jul 4, 2025
Merged

Fix stray \ before + error caused by grep in load_eessi_extend_module.sh #28

ocaisa merged 1 commit into from
Jul 4, 2025

Conversation

@bedroge
Copy link
Contributor

@bedroge bedroge commented Jul 4, 2025

While inspecting the log of a build done in #27, I found this warning:

grep: warning: stray \ before +

It's caused by a grep in load_eessi_extend_module.sh, and can be reproduced with the grep from our compat layer:

$ /cvmfs/software.eessi.io/versions/2023.06/compat/linux/x86_64/startprefix 
Entering Gentoo Prefix /cvmfs/software.eessi.io/versions/2023.06/compat/linux/x86_64

$ echo "+++ b/EESSI-extend" | grep "^\+\+\+ b/"
grep: warning: stray \ before +
+++ b/EESSI-extend

But it shouldn't be necessary to escape the +:

$ echo "+++ b/EESSI-extend" | grep "^+++ b/"
+++ b/EESSI-extend

ocaisa
ocaisa approved these changes Jul 4, 2025
View reviewed changes
Copy link
Member

@ocaisa ocaisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ocaisa ocaisa merged commit 0511be3 into EESSI:main Jul 4, 2025
51 checks passed
@bedroge bedroge deleted the fix_grep branch July 4, 2025 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ocaisa ocaisa ocaisa approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bedroge @ocaisa